Checkboxradio: Fix label handling with jQuery 3.x #1720
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@scottgonzalez, thanks for your PR! By analyzing the annotation information on this pull request, we identified @arschmitz and @jzaefferer to be potential reviewers |
Member
|
Looks fine to me |
Member
Author
|
And here's the bug for jQuery Core: jquery/jquery#3226 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs to have a ticket filed before I merge this, but I wanted to get a review.
This was caused by jquery/jquery@0e2f8f9 which @gibson042 views as a bug in core.